Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated get_customer_list #34624

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Mar 28, 2023

get_customer_list has been deprecated and replaced via #34563, the deprecation notice has been released in v14.

I'll put this in draft mode to wait for a couple of weeks before merging.

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 28, 2023
@barredterra barredterra marked this pull request as draft March 28, 2023 20:03
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Mar 28, 2023
@barredterra barredterra changed the title feat: remove deprecated method feat: remove deprecated get_customer_list Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #34624 (2902c81) into develop (682730a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34624   +/-   ##
========================================
  Coverage    63.84%   63.85%           
========================================
  Files          810      810           
  Lines        59661    59644   -17     
========================================
- Hits         38088    38083    -5     
+ Misses       21573    21561   -12     
Impacted Files Coverage Δ
erpnext/selling/doctype/customer/customer.py 75.85% <ø> (+2.85%) ⬆️

... and 1 file with indirect coverage changes

@barredterra barredterra marked this pull request as ready for review April 3, 2023 10:24
@deepeshgarg007 deepeshgarg007 merged commit e6a9b6e into frappe:develop Apr 5, 2023
@barredterra barredterra deleted the remove-get_customer_list branch April 5, 2023 10:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants