Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect balance qty in the stock ledger report #34664

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Mar 30, 2023

Issue

This can only be replicated if batch filter has selected.

Screenshot 2023-03-30 at 4 19 25 PM

After Fix

Screenshot 2023-03-30 at 4 19 33 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 30, 2023
@rohitwaghchaure rohitwaghchaure added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #34664 (cbdaab9) into develop (867d898) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34664      +/-   ##
===========================================
- Coverage    63.80%   63.80%   -0.01%     
===========================================
  Files          810      810              
  Lines        59533    59536       +3     
===========================================
+ Hits         37983    37984       +1     
- Misses       21550    21552       +2     
Impacted Files Coverage Δ
erpnext/stock/report/stock_ledger/stock_ledger.py 75.59% <100.00%> (+0.44%) ⬆️

... and 3 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 06eac67 into frappe:develop Mar 30, 2023
rohitwaghchaure added a commit that referenced this pull request Mar 30, 2023
…-34664

fix: incorrect balance qty in the stock ledger report (backport #34664)
rohitwaghchaure added a commit that referenced this pull request Mar 30, 2023
…-34664

fix: incorrect balance qty in the stock ledger report (backport #34664)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant