Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider qty field precision #34713

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Apr 3, 2023

Source / Ref: ISS-22-23-06369

Steps to Replicate:

  • Create an Item with Stock UOM as Nos and set Units of Measure for a fractional UOM.
    image
  • Update the Purchase Order Item Conversion Factor Precision to 5 (using Customize Form).
    image
  • Now, create a Purchase Order for 75.900 Kg (3 Nos), Conversion Factor will be 0.03953. While saving you will get the below error.
    image
    image

Solution: Consider Qty in Stock UOM Precision while comparing.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 3, 2023
@s-aga-r s-aga-r added backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #34713 (4571bd5) into develop (1eefd51) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34713   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          810      810           
  Lines        59663    59663           
========================================
  Hits         38088    38088           
  Misses       21575    21575           
Impacted Files Coverage Δ
erpnext/utilities/transaction_base.py 87.50% <100.00%> (ø)

@s-aga-r s-aga-r marked this pull request as ready for review April 3, 2023 09:51
@s-aga-r s-aga-r merged commit 5f28747 into frappe:develop Apr 3, 2023
s-aga-r added a commit that referenced this pull request Apr 4, 2023
…-34713

fix: consider qty field precision (backport #34713)
@s-aga-r s-aga-r deleted the FIX-ISS-22-23-06369 branch April 15, 2023 09:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant