-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: don't book exchange gain/loss for sales/purchase orders #35061
Merged
ruthra-kumar
merged 2 commits into
frappe:develop
from
ruthra-kumar:refactor_pe_dont_book_gain_loss_for_sales_purchase_orders
May 2, 2023
Merged
refactor: don't book exchange gain/loss for sales/purchase orders #35061
ruthra-kumar
merged 2 commits into
frappe:develop
from
ruthra-kumar:refactor_pe_dont_book_gain_loss_for_sales_purchase_orders
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a56de8e
to
f00bbe4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35061 +/- ##
========================================
Coverage 63.69% 63.70%
========================================
Files 813 813
Lines 60007 60030 +23
========================================
+ Hits 38221 38240 +19
- Misses 21786 21790 +4
|
f00bbe4
to
5bd3d62
Compare
This was referenced Apr 27, 2023
Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See similar logic being used for the exchange rate in both places, maybe move this to a function and use that?
Also if we can add a simple unit test for this
5bd3d62
to
ce4e18c
Compare
ruthra-kumar
added a commit
that referenced
this pull request
May 2, 2023
…-35061 refactor: don't book exchange gain/loss for sales/purchase orders (backport #35061)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't book Exchange Gain/Loss while referencing Sales/Purchase Order
Sales/Purchase Orders don't have any accounting impact. So, Booking Gain/Loss for a Multi-Currency Order doesn't make sense.