fix: incorrect paid_amount and exchange rate in Payment Entry #35107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Company master has no default cash or bank account set but Party has default company bank account set. In this case, paid_amount and conversion rate are not calculated correctly
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35107 +/- ##
===========================================
- Coverage 63.69% 63.69% -0.01%
===========================================
Files 813 813
Lines 60007 60029 +22
===========================================
+ Hits 38221 38234 +13
- Misses 21786 21795 +9
|
ruthra-kumar
changed the title
ruthra-kumar
added a commit
that referenced
this pull request
May 2, 2023
…-35107 fix: incorrect paid_amount and exchange rate in Payment Entry (backport #35107)
ruthra-kumar
deleted the
fix_incorrect_paid_amount_if_bank_cash_account_missing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
CashandBankaccount unset in Company master and Party hasDefault Company Bank Account. In such cases, creating Payment against a Sales/Purchase Invoice has incorrect paid/received amount and the exchange rate is not fetched.Fixing in this PR.
Company master:
Customer master:
Invoice in foreign currency for above party:
before fix - Incorrect exchange rate and amount:
after fix:
