Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configuration to notify reposting errors to specific role #35161

Merged
merged 1 commit into from
May 4, 2023
Merged

feat: configuration to notify reposting errors to specific role #35161

merged 1 commit into from
May 4, 2023

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented May 4, 2023 •
edited
Loading

Screenshot 2023-05-04 at 4 49 38 PM

#no-docs

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #35161 (c7b6201) into develop (9aa6465) will increase coverage by 0.01%.
The diff coverage is 80.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35161      +/-   ##
===========================================
+ Coverage    63.69%   63.71%   +0.01%     
===========================================
  Files          813      813              
  Lines        60032    60098      +66     
===========================================
+ Hits         38239    38292      +53     
- Misses       21793    21806      +13
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 73.68% <80.00%> (+1.34%) ⬆️

... and 12 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 3993bfd into frappe:develop May 4, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label May 4, 2023
@mergify mergify bot mentioned this pull request May 4, 2023
Merged
rohitwaghchaure added a commit that referenced this pull request May 4, 2023
@rohitwaghchaure
Merge pull request #35166 from frappe/mergify/bp/version-14-hotfix/pr…
c463df4 
…-35161

feat: configuration to notify reposting errors to specific role (backport #35161)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rohitwaghchaure