Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not allow to transfer excess materials against the job card #35167

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Disabled the "Allow Excess Material Transfer" in the "Manufacturing Settings"
  2. Create a work order with operations and set "Transfer Material Against" as "Job Card"
  3. Submit the work order, system will create the job cards for operations.
  4. Open a job card, click on "Material Transfer"
  5. System will open the stock entry with raw materials
  6. Now Manually add one more row for raw materials without reference of Job Card Item and submit the stock entry
  7. System allowed to Transfer Excess Materials against the job card even though "Allow Excess Material Transfer" has disabled in the "Manufacturing Settings"

After Fix

System will throw below error
image

@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #35167 (8167b24) into develop (3993bfd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35167   +/-   ##
========================================
  Coverage    63.71%   63.72%           
========================================
  Files          813      813           
  Lines        60102    60113   +11     
========================================
+ Hits         38296    38307   +11     
  Misses       21806    21806           
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 84.35% <100.00%> (+0.13%) ⬆️

@rohitwaghchaure rohitwaghchaure merged commit 7fb1e5b into frappe:develop May 4, 2023
13 checks passed
rohitwaghchaure added a commit that referenced this pull request May 4, 2023
…-35167

fix: not allow to transfer excess materials against the job card (backport #35167)
rohitwaghchaure added a commit that referenced this pull request May 4, 2023
fix: not allow to transfer excess materials against the job card (backport #35167) (backport #35169)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant