Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inventory dimension for material transfer not working #35224

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented May 9, 2023

Issue

Crate material transfer entry for inventory dimension, you will see system has picked only Source Dimension and not Target Dimension in the Stock Ledger Entries.
Screenshot 2023-05-12 at 6 00 53 PM

After Fix

Stock Entry
Screenshot 2023-05-12 at 5 57 39 PM

Stock Ledger Entry
Screenshot 2023-05-12 at 5 57 01 PM

@rohitwaghchaure rohitwaghchaure marked this pull request as draft May 9, 2023 10:39
@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #35224 (7d722f6) into develop (a686b8c) will decrease coverage by 0.01%.
The diff coverage is 96.77%.

❗ Current head 7d722f6 differs from pull request most recent head 6798b90. Consider uploading reports for the commit 6798b90 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35224      +/-   ##
===========================================
- Coverage    63.78%   63.78%   -0.01%     
===========================================
  Files          813      813              
  Lines        60145    60172      +27     
===========================================
+ Hits         38365    38379      +14     
- Misses       21780    21793      +13     
Impacted Files Coverage Δ
...doctype/inventory_dimension/inventory_dimension.py 93.82% <96.07%> (+0.38%) ⬆️
erpnext/controllers/stock_controller.py 92.93% <100.00%> (-0.07%) ⬇️

... and 6 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-inventory-dimension-for-material-transfer-not-working branch from 7d722f6 to 46b5403 Compare May 12, 2023 12:24
@rohitwaghchaure rohitwaghchaure removed the needs-tests This PR needs automated unit-tests. label May 12, 2023
@rohitwaghchaure rohitwaghchaure marked this pull request as ready for review May 12, 2023 12:34
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-inventory-dimension-for-material-transfer-not-working branch 4 times, most recently from 251677e to 75c0f99 Compare May 12, 2023 19:11
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-inventory-dimension-for-material-transfer-not-working branch from 75c0f99 to 6798b90 Compare May 12, 2023 20:14
@rohitwaghchaure rohitwaghchaure added backport version-14-hotfix backport to version 14 and removed stock labels May 12, 2023
@rohitwaghchaure rohitwaghchaure merged commit e7bb6ad into frappe:develop May 12, 2023
10 of 11 checks passed
rohitwaghchaure added a commit that referenced this pull request May 13, 2023
…-35224

fix: inventory dimension for material transfer not working (backport #35224)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant