Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pick List Status #35306

Merged
merged 2 commits into from
May 17, 2023
Merged

fix: Pick List Status #35306

merged 2 commits into from
May 17, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented May 15, 2023

Issue: While amending the cancelled document the field values get copied to the new document even if no-copy is checked.

Solution: Fix Pick List update_status() to set the correct status on save.

Before:

Screencast.from.2023-05-17.16-03-02.webm

After:

Screencast.from.2023-05-17.16-04-00.webm

Closes: #35014

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 15, 2023
@s-aga-r s-aga-r added bug backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels May 15, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #35306 (fcea907) into develop (adf2474) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35306   +/-   ##
========================================
  Coverage    63.82%   63.82%           
========================================
  Files          813      813           
  Lines        60215    60215           
========================================
+ Hits         38434    38435    +1     
+ Misses       21781    21780    -1     
Impacted Files Coverage Δ
erpnext/stock/doctype/pick_list/pick_list.py 81.28% <100.00%> (+0.18%) ⬆️

@s-aga-r s-aga-r force-pushed the FIX-35014 branch 2 times, most recently from 199e43e to 9fb8b18 Compare May 17, 2023 10:38
@s-aga-r s-aga-r marked this pull request as ready for review May 17, 2023 12:42
@s-aga-r s-aga-r merged commit cf0d37c into frappe:develop May 17, 2023
12 checks passed
s-aga-r added a commit that referenced this pull request May 18, 2023
@s-aga-r s-aga-r removed the backport version-14-hotfix backport to version 14 label May 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pick list -- Stock Entry Cancelled - Pick - list as completed
1 participant