Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect depr schedule and posting dates on selling of existing assets [dev] #35398

Merged
merged 3 commits into from
May 24, 2023
Merged

fix: incorrect depr schedule and posting dates on selling of existing assets [dev] #35398

merged 3 commits into from
May 24, 2023

Conversation

anandbaburajan
Copy link
Contributor

Description: asset.docx (from #35159). Fixes #35159.

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #35398 (b021336) into develop (3940deb) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35398   +/-   ##
========================================
  Coverage    63.82%   63.82%           
========================================
  Files          813      813           
  Lines        60260    60266    +6     
========================================
+ Hits         38460    38466    +6     
  Misses       21800    21800           
Impacted Files Coverage Δ
...xt/accounts/doctype/sales_invoice/sales_invoice.py 82.14% <ø> (+0.08%) ⬆️
...ctype/asset_capitalization/asset_capitalization.py 92.87% <ø> (ø)
erpnext/assets/doctype/asset/depreciation.py 82.02% <71.42%> (-0.36%) ⬇️
...preciation_schedule/asset_depreciation_schedule.py 91.52% <100.00%> (ø)

... and 1 file with indirect coverage changes

@anandbaburajan anandbaburajan merged commit edb7b0d into frappe:develop May 24, 2023
11 of 12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset Wrong Deprecation Amount Calculation on Selling of Asset
1 participant