fix: set Phone option on contact_{mobile,phone} for SMS notification #35549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fields with options 'Phone' are selectable as recepients_by_field
in the notification doctype.
This fix sets sane defaults across all doctypes that have
contact_{mobile,phone} fields
blaggacao
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
|
|
|
@deepeshgarg007 Would you mind whitelisting the workflow runs? |
|
Thanks for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fields with options 'Phone' are selectable as recepients_by_field
in the notification doctype.
This fix sets sane defaults across all doctypes that have
contact_{mobile,phone} fields
This is a side effect of this frappe implementation