Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset entries qty to 1 for serial item #35618

Merged
merged 4 commits into from
Jun 9, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jun 9, 2023

Issue: There is a 1:1 mapping between Serial No and Serial and Batch Entry, the system should validate the same.

Steps to Replicate:

  • Create a Serial and Batch Bundle for Serial Item, select Serial No and set the Qty > 1.
  • Create a Delivery Note, select that bundle and check the Stock Ledger after submitting.

Serial and Batch Bundle

image

Delivery Note

image

Stock Ledger Entry

image

Changes:

  • Reset the Qty to 1 and make the field read-only for serial item
  • Set child table row warehouse as parent warehouse

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 9, 2023
@s-aga-r s-aga-r marked this pull request as ready for review June 9, 2023 06:37
@s-aga-r s-aga-r added the dont squash Don't squash and merge label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #35618 (b5c5a90) into develop (992d61b) will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35618      +/-   ##
===========================================
- Coverage    63.92%   63.92%   -0.01%     
===========================================
  Files          812      812              
  Lines        61785    61780       -5     
===========================================
- Hits         39499    39495       -4     
+ Misses       22286    22285       -1     
Impacted Files Coverage Δ
erpnext/projects/doctype/task/task.py 65.19% <0.00%> (-0.29%) ⬇️
erpnext/accounts/party.py 77.56% <100.00%> (+0.17%) ⬆️
...serial_and_batch_bundle/serial_and_batch_bundle.py 70.23% <100.00%> (ø)

@s-aga-r s-aga-r merged commit e3802d1 into frappe:develop Jun 9, 2023
13 checks passed
@s-aga-r s-aga-r deleted the FIX-SBB-SERIAL-NO-QTY branch July 27, 2023 08:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do not backport dont squash Don't squash and merge needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant