Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test case PyPDF2 #35652

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
      f = <built-in function exec>
      args = (<code object <module> at 0x7f4010751240, file "/home/runner/frappe-bench/apps/erpnext/erpnext/regional/united_states/test_united_states.py", line 1>, {'__name__': 'erpnext.regional.united_states.test_united_states', '__doc__': None, '__package__': 'erpnext.regional.united_states', '__loader__': <_frozen_importlib_external.SourceFileLoader object at 0x7f4011d33d50>, '__spec__': ModuleSpec(name='erpnext.regional.united_states.test_united_states', loader=<_frozen_importlib_external.SourceFileLoader object at 0x7f4011d33d50>, origin='/home/runner/frappe-bench/apps/erpnext/erpnext/regional/united_states/test_united_states.py'), '__file__': '/home/runner/frappe-bench/apps/erpnext/erpnext/regional/united_states/test_united_states.py', '__cached__': '/home/runner/frappe-bench/apps/erpnext/erpnext/regional/united_states/__pycache__/test_united_states.cpython-311.pyc', '__builtins__': {'__name__': 'builtins', '__doc__': "Built-in functions, exceptions, and other objects.\n\nNoteworthy: None is ...
      kwds = {}
  File "/home/runner/frappe-bench/apps/erpnext/erpnext/regional/united_states/test_united_states.py", line 8, in <module>
    from erpnext.regional.report.irs_1099.irs_1099 import execute as execute_1099_report
      ...skipped... 10 vars
  File "/home/runner/frappe-bench/apps/erpnext/erpnext/regional/report/irs_1099/irs_1099.py", line 13, in <module>
    from PyPDF2 import PdfWriter
      ...skipped... 17 vars
builtins.ModuleNotFoundError: No module named 'PyPDF2'

Replaced pypdf2 to pypdf

Ref frappe/frappe#21232

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 12, 2023
@rohitwaghchaure rohitwaghchaure changed the title fix: test case fix: test case PyPDF2 Jun 12, 2023
@ankush ankush merged commit 6201141 into frappe:develop Jun 12, 2023
13 checks passed
@ankush ankush removed the needs-tests This PR needs automated unit-tests. label Jun 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants