Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation of job card in stock entry #35756

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Jun 17, 2023

Issue

job_card_item reference not set for the FG Item and therefore this validation is showing for the custom code.

Screenshot 2023-06-17 at 12 14 01 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 17, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-stock-entry-not-able-to-save branch from 082d3e5 to df8c3f0 Compare June 17, 2023 07:16
@rohitwaghchaure rohitwaghchaure added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Jun 17, 2023
@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #35756 (df8c3f0) into develop (24d1bf2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35756      +/-   ##
===========================================
+ Coverage    64.11%   64.13%   +0.02%     
===========================================
  Files          811      810       -1     
  Lines        61892    61893       +1     
===========================================
+ Hits         39680    39695      +15     
+ Misses       22212    22198      -14     
Impacted Files Coverage Δ
erpnext/stock/doctype/stock_entry/stock_entry.py 82.17% <100.00%> (ø)

... and 8 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit c51e6db into frappe:develop Jun 17, 2023
12 checks passed
rohitwaghchaure added a commit that referenced this pull request Jun 17, 2023
…-35756

fix: validation of job card in stock entry (backport #35756)
rohitwaghchaure added a commit that referenced this pull request Jun 17, 2023
fix: validation of job card in stock entry (backport #35756) (backport #35759)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant