Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return against rejected warehouse (UX Issue) #35829

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

When the user creates a Purchase Return Entry from the Purchase Receipt, the system automatically populates the Received Quantity and Rejected Quantity fields. However, users need to manually set the Received Qty same as Rejected Qty and the Received Warehouse same as the Rejected Warehouse in the purchase return entry to return the rejected quantity. The user experience (UX) can be confusing, especially for new users who often struggle to understand this process.

returned-issue

Solution

To solve this problem, a modal has been added where the user must select whether they want to return the material from the rejected warehouse or the accepted warehouse.

returned-solution

Fix #35811

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #35829 (756dbe7) into develop (c51e6db) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35829      +/-   ##
===========================================
+ Coverage    64.13%   64.28%   +0.14%     
===========================================
  Files          810      811       +1     
  Lines        61893    62061     +168     
===========================================
+ Hits         39696    39896     +200     
+ Misses       22197    22165      -32     
Impacted Files Coverage Δ
erpnext/controllers/sales_and_purchase_return.py 87.38% <100.00%> (+0.24%) ⬆️
...stock/doctype/purchase_receipt/purchase_receipt.py 91.33% <100.00%> (+0.07%) ⬆️

... and 16 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit d1bccc8 into frappe:develop Jun 22, 2023
12 of 14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purchase Return || Incorrect Qty, Warehouse and Rate
1 participant