Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect idx on Journals after reconciliation #36126

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jul 14, 2023

When reconciling Journal Entries, the newly created rows in Journal have incorrect idx value. Fixing here.

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #36126 (72f577a) into develop (c16a581) will increase coverage by 0.00%.
The diff coverage is 60.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #36126   +/-   ##
========================================
  Coverage    64.20%   64.21%           
========================================
  Files          785      785           
  Lines        60703    60681   -22     
========================================
- Hits         38975    38965   -10     
+ Misses       21728    21716   -12     
Impacted Files Coverage Δ
...ange_rate_revaluation/exchange_rate_revaluation.py 55.98% <0.00%> (ø)
erpnext/stock/doctype/item/item.py 85.66% <0.00%> (ø)
erpnext/assets/doctype/asset/depreciation.py 81.31% <23.07%> (ø)
erpnext/controllers/stock_controller.py 82.49% <50.00%> (ø)
...xt/assets/doctype/asset_movement/asset_movement.py 77.61% <60.00%> (+4.75%) ⬆️
erpnext/controllers/buying_controller.py 84.66% <66.66%> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 83.31% <77.77%> (ø)
...e/subcontracting_receipt/subcontracting_receipt.py 90.25% <85.71%> (ø)
erpnext/accounts/utils.py 73.70% <100.00%> (ø)
erpnext/controllers/sales_and_purchase_return.py 87.38% <100.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

@ruthra-kumar ruthra-kumar changed the title fix: incorrect idx on JE's after reconciliation fix: incorrect idx on Journals after reconciliation Jul 14, 2023
@ruthra-kumar ruthra-kumar merged commit 50d294f into frappe:develop Jul 28, 2023
16 checks passed
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 and removed accounts labels Jul 28, 2023
ruthra-kumar added a commit that referenced this pull request Aug 1, 2023
…-36126

fix: incorrect `idx` on Journals after reconciliation (backport #36126)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant