Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ci): add eslint and update linting confs #36147

Merged
merged 14 commits into from
Jul 24, 2023
Merged

refactor(ci): add eslint and update linting confs #36147

merged 14 commits into from
Jul 24, 2023

Conversation

deepeshgarg007
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #36147 (cdc9b62) into develop (04400eb) will decrease coverage by 0.07%.
The diff coverage is 58.62%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #36147      +/-   ##
===========================================
- Coverage    64.21%   64.14%   -0.07%     
===========================================
  Files          785      784       -1     
  Lines        60681    60715      +34     
===========================================
- Hits         38965    38947      -18     
- Misses       21716    21768      +52
Impacted Files Coverage Δ
erpnext/accounts/report/financial_statements.py 31.07% <ø> (+0.11%) ⬆️
...ext/accounts/report/trial_balance/trial_balance.py 0.00% <ø> (ø)
...ype/item_variant_settings/item_variant_settings.py 80.00% <ø> (ø)
erpnext/telephony/doctype/call_log/call_log.py 37.62% <6.66%> (-42.77%) ⬇️
...ctype/accounting_dimension/accounting_dimension.py 63.97% <25.00%> (ø)
erpnext/setup/doctype/holiday_list/holiday_list.py 77.17% <81.57%> (+35.63%) ⬆️
...cturing/doctype/production_plan/production_plan.py 80.20% <100.00%> (ø)

... and 26 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 changed the title ci: add eslint and update linting confs ci(refactor): add eslint and update linting confs Jul 18, 2023
@deepeshgarg007 deepeshgarg007 changed the title ci(refactor): add eslint and update linting confs refactor: add eslint and update linting confs Jul 18, 2023
@deepeshgarg007 deepeshgarg007 changed the title refactor: add eslint and update linting confs refactor(ci): add eslint and update linting confs Jul 18, 2023
@ankush ankush linked an issue Jul 24, 2023 that may be closed by this pull request
Setup ESLint for trivial JS errors #35708
Closed
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 24, 2023
Merged
@deepeshgarg007 deepeshgarg007 merged commit 3f81e15 into frappe:develop Jul 24, 2023
13 checks passed
cogk added a commit to cogk/erpnext that referenced this pull request Jul 25, 2023
@cogk
fix(taxes_and_totals.js): Fix initialize_taxes incorrect refactor
d69af74 
Following changes from PR frappe#36147, `cur_frm.cscript.validate_taxes_and_charges` is not a method anymore and should be replaced with the `erpnext.accounts.taxes.validate_taxes_and_charges` function.
@cogk cogk mentioned this pull request Jul 25, 2023
Merged
@ankush ankush mentioned this pull request Jul 30, 2023
Closed
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

@anandbaburajan anandbaburajan Awaiting requested review from anandbaburajan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup ESLint for trivial JS errors
1 participant
@deepeshgarg007