-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show tax withholding category details for customers #36196
fix: show tax withholding category details for customers #36196
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36196 +/- ##
===========================================
- Coverage 64.14% 64.11% -0.04%
===========================================
Files 785 784 -1
Lines 60749 60757 +8
===========================================
- Hits 38970 38954 -16
- Misses 21779 21803 +24
|
6366f7a
to
5224f13
Compare
…omer-details-in-tax-withholding-category-report
"label": __("Party Type"), | ||
"fieldtype": "Select", | ||
"options": ["Supplier", "Customer"], | ||
"reqd": 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the default value as "Supplier"
@@ -262,6 +262,7 @@ erpnext.patches.v14_0.update_reference_due_date_in_journal_entry | |||
erpnext.patches.v15_0.saudi_depreciation_warning | |||
erpnext.patches.v15_0.delete_saudi_doctypes | |||
erpnext.patches.v14_0.show_loan_management_deprecation_warning | |||
execute:frappe.rename_doc("Report", "TDS Payable Monthly", "Tax Withholding Details", force=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to [post_model_sync]
? Seems to break my migration otherwise (rename_doc
triggers a query on tabDocType.is_virtual
, which does not exists at that time).
Problem
Solution