Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show tax withholding category details for customers #36196

Conversation

GursheenK
Copy link
Member

@GursheenK GursheenK commented Jul 19, 2023

Problem

  • The TDS Payable Monthly Report fetches tax details of both Purchase Invoices and Sales Invoices. However, the party details and total amount(without tax) of only purchase invoices is displayed correctly.
  • The results can only be filtered by Supplier.
Screenshot 2023-07-19 at 6 26 24 PM

Solution

  • Added logic to fetch and show Customer details and the total amount(without tax) for Sales Invoices.
  • Added a mandatory filter for Party Type which allows filtering results for both Suppliers and Customers.
Screenshot 2023-07-24 at 12 22 42 PM Screenshot 2023-07-24 at 12 22 59 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #36196 (5224f13) into develop (3055430) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 5224f13 differs from pull request most recent head 8c410c6. Consider uploading reports for the commit 8c410c6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36196      +/-   ##
===========================================
- Coverage    64.14%   64.11%   -0.04%     
===========================================
  Files          785      784       -1     
  Lines        60749    60757       +8     
===========================================
- Hits         38970    38954      -16     
- Misses       21779    21803      +24     
Files Changed Coverage Δ
...tax_withholding_details/tax_withholding_details.py 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

@GursheenK GursheenK marked this pull request as ready for review July 24, 2023 08:45
@GursheenK GursheenK force-pushed the customer-details-in-tax-withholding-category-report branch from 6366f7a to 5224f13 Compare July 24, 2023 11:41
@deepeshgarg007 deepeshgarg007 merged commit 6830a87 into frappe:develop Jul 25, 2023
11 checks passed
"label": __("Party Type"),
"fieldtype": "Select",
"options": ["Supplier", "Customer"],
"reqd": 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the default value as "Supplier"

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
@@ -262,6 +262,7 @@ erpnext.patches.v14_0.update_reference_due_date_in_journal_entry
erpnext.patches.v15_0.saudi_depreciation_warning
erpnext.patches.v15_0.delete_saudi_doctypes
erpnext.patches.v14_0.show_loan_management_deprecation_warning
execute:frappe.rename_doc("Report", "TDS Payable Monthly", "Tax Withholding Details", force=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to [post_model_sync]? Seems to break my migration otherwise (rename_doc triggers a query on tabDocType.is_virtual, which does not exists at that time).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants