fix: multiple fixes on payment terms based issues in payment entry #36241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fixed broken `payment_term` filter in Payment References section 2. Throw error if user fails to select 'Payment Term' for an invoice with 'Payment Term based allocation' enabled.
ruthra-kumar
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36241 +/- ##
========================================
Coverage 64.14% 64.14%
========================================
Files 784 784
Lines 60715 60730 +15
========================================
+ Hits 38946 38956 +10
- Misses 21769 21774 +5
|
ruthra-kumar
added a commit
that referenced
this pull request
Jul 24, 2023
…-36241 fix: multiple fixes on payment terms based issues in payment entry (backport #36241)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Payment Term query in Payment References section
Payment Termselect field wasn't giving any results.before:
after:
2. Incorrect Validation Error for term based allocation
If Payment Term based allocation has been enabled for an invoice, term has to be selected in references section.
before:
When no term was selected, validation miscalculated that invoice as fully paid.
after:
3. Incorrect Validation Err for Invoice without any payment template or term
An Invoice without any Payment Terms Template or Payment Term, was incorrectly throwing fully paid validation error. Its fixed now.
before:
after:
