-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Naming Series preview when no previous transaction present #36364
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36364 +/- ##
===========================================
+ Coverage 64.46% 64.82% +0.36%
===========================================
Files 785 792 +7
Lines 60836 61802 +966
===========================================
+ Hits 39216 40064 +848
- Misses 21620 21738 +118
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Active |
@deepeshgarg007 Any issues with this PR? |
@SvbZ3r0 doc is still being accessed on line no 1121, so this change might not full resolve the error that you encountered |
Ahh got it. My bad. I'll correct that. |
@SvbZ3r0 Can you add a basic test case for this? codecov check failing |
I.. uh.. have no idea how to write a test case. Point me in the right direction and i will try. |
Fixes Naming Series preview error mentioned in #36234