Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Naming Series preview when no previous transaction present #36364

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

SvbZ3r0
Copy link
Contributor

@SvbZ3r0 SvbZ3r0 commented Jul 27, 2023

Fixes Naming Series preview error mentioned in #36234

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #36364 (cdf100d) into develop (4f9242d) will increase coverage by 0.36%.
Report is 477 commits behind head on develop.
The diff coverage is 61.47%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36364      +/-   ##
===========================================
+ Coverage    64.46%   64.82%   +0.36%     
===========================================
  Files          785      792       +7     
  Lines        60836    61802     +966     
===========================================
+ Hits         39216    40064     +848     
- Misses       21620    21738     +118     
Files Changed Coverage Δ
...ement_of_accounts/process_statement_of_accounts.py 0.00% <ø> (ø)
...cial_statement/consolidated_financial_statement.py 75.14% <ø> (-14.15%) ⬇️
...pnext/accounts/report/pos_register/pos_register.py 0.00% <0.00%> (ø)
...t/profitability_analysis/profitability_analysis.py 0.00% <0.00%> (ø)
...tax_withholding_details/tax_withholding_details.py 0.00% <0.00%> (ø)
erpnext/accounts/utils.py 73.60% <0.00%> (+0.16%) ⬆️
...eport/fixed_asset_register/fixed_asset_register.py 0.00% <0.00%> (ø)
erpnext/controllers/accounts_controller.py 86.11% <ø> (+0.43%) ⬆️
...t/crm/doctype/twitter_settings/twitter_settings.py 0.00% <0.00%> (ø)
...uring/doctype/bom_update_log/bom_updation_utils.py 44.23% <ø> (-1.32%) ⬇️
... and 46 more

... and 40 files with indirect coverage changes

@stale
Copy link

stale bot commented Aug 11, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 11, 2023
@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Aug 12, 2023

Active

@stale stale bot removed the inactive label Aug 12, 2023
@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Aug 14, 2023

@deepeshgarg007 Any issues with this PR?

@deepeshgarg007
Copy link
Member

@SvbZ3r0 doc is still being accessed on line no 1121, so this change might not full resolve the error that you encountered

@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Aug 14, 2023

Ahh got it. My bad. I'll correct that.

@deepeshgarg007
Copy link
Member

@SvbZ3r0 Can you add a basic test case for this? codecov check failing

@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Aug 17, 2023

I.. uh.. have no idea how to write a test case. Point me in the right direction and i will try.

@stale stale bot added the inactive label Sep 3, 2023
@frappe frappe deleted a comment from stale bot Sep 4, 2023
@stale stale bot removed the inactive label Sep 4, 2023
@deepeshgarg007 deepeshgarg007 merged commit 7bfd487 into frappe:develop Sep 13, 2023
12 of 14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants