Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix query for financial statement report #36450

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Aug 1, 2023

A simple typo I believe @GursheenK #36303

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #36450 (bd3fc7c) into develop (ba15810) will increase coverage by 0.01%.
Report is 52 commits behind head on develop.
The diff coverage is 84.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36450      +/-   ##
===========================================
+ Coverage    64.52%   64.54%   +0.01%     
===========================================
  Files          786      787       +1     
  Lines        61123    61171      +48     
===========================================
+ Hits         39440    39483      +43     
- Misses       21683    21688       +5     
Files Changed Coverage Δ
...ccounts/doctype/loyalty_program/loyalty_program.py 75.60% <0.00%> (ø)
...ext/accounts/report/trial_balance/trial_balance.py 81.97% <ø> (ø)
...eport/voucher_wise_balance/voucher_wise_balance.py 0.00% <ø> (ø)
erpnext/controllers/website_list_for_contact.py 56.02% <0.00%> (ø)
...facturing/doctype/bom_update_log/bom_update_log.py 43.36% <ø> (ø)
...uring/doctype/bom_update_log/bom_updation_utils.py 44.23% <0.00%> (ø)
erpnext/manufacturing/doctype/job_card/job_card.py 72.84% <0.00%> (ø)
...t/manufacturing/doctype/workstation/workstation.py 88.15% <0.00%> (ø)
...rpnext/stock/report/stock_balance/stock_balance.py 88.84% <ø> (ø)
erpnext/stock/report/stock_ledger/stock_ledger.py 66.66% <ø> (ø)
... and 19 more

... and 3 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Aug 1, 2023
@deepeshgarg007 deepeshgarg007 merged commit b715453 into frappe:develop Aug 1, 2023
15 checks passed
deepeshgarg007 added a commit that referenced this pull request Aug 1, 2023
…-36450

fix: Fix query for financial statement report (backport #36450)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants