Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: POS compatible for mobile view #36534

Merged

Conversation

RitvikSardana
Copy link
Contributor

Issue:
POS was not compatible for Mobile View

Solution:
Modified the pos.scss file to make POS compatible.

POS.Mobile.View.mov

@RitvikSardana RitvikSardana linked an issue Aug 7, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #36534 (7cee1f9) into develop (10529e1) will increase coverage by 0.10%.
Report is 79 commits behind head on develop.
The diff coverage is 45.50%.

❗ Current head 7cee1f9 differs from pull request most recent head e3c4cb6. Consider uploading reports for the commit e3c4cb6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36534      +/-   ##
===========================================
+ Coverage    64.54%   64.65%   +0.10%     
===========================================
  Files          787      789       +2     
  Lines        61176    61461     +285     
===========================================
+ Hits         39486    39737     +251     
- Misses       21690    21724      +34     
Files Changed Coverage Δ
...counts/report/accounts_payable/accounts_payable.py 100.00% <ø> (ø)
...counts_payable_summary/accounts_payable_summary.py 0.00% <ø> (ø)
..._receivable_summary/accounts_receivable_summary.py 0.00% <0.00%> (ø)
...counts/report/financial_ratios/financial_ratios.py 0.00% <0.00%> (ø)
erpnext/crm/doctype/lead/lead.py 68.03% <ø> (ø)
erpnext/accounts/party.py 77.40% <9.09%> (-0.76%) ⬇️
erpnext/accounts/doctype/account/account.py 73.18% <57.14%> (-0.42%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.05% <60.00%> (-1.62%) ⬇️
erpnext/accounts/utils.py 73.85% <87.87%> (+0.41%) ⬆️
...xt/accounts/doctype/journal_entry/journal_entry.py 69.32% <90.90%> (+0.25%) ⬆️
... and 8 more

... and 13 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit ae2c600 into frappe:develop Aug 13, 2023
11 of 12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POS not easily usable on mobile view
2 participants