Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RFQ): hide description in print and report #36554

Merged

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Aug 8, 2023

The Jinja variables from the HTML description were evaluated in print preview using standard print format and caused issues there.

This PR hides the HTML description in print and report.

Introduced with #36353.
Cherry-pick into backport #36531 after merge. ✅

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #36554 (4fb844a) into develop (68ad62f) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #36554   +/-   ##
========================================
  Coverage    64.64%   64.64%           
========================================
  Files          789      789           
  Lines        61472    61472           
========================================
+ Hits         39737    39738    +1     
+ Misses       21735    21734    -1     

see 1 file with indirect coverage changes

@s-aga-r s-aga-r merged commit e415cb2 into frappe:develop Aug 9, 2023
18 checks passed
@barredterra barredterra deleted the hide-description-in-print-and-report branch August 9, 2023 08:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants