Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: toggle for negative item rates in Selling Settings #36642

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 14, 2023

There are some customers who use negative rates and want that option. Adding a checkbox in Selling settings to make it configurable.

Screenshot 2023-08-15 at 7 36 10 AM Screenshot 2023-08-14 at 5 45 50 PM

continues: #36027

@ruthra-kumar ruthra-kumar changed the title refactor: toggle for negative rates in Selling Settings refactor: toggle for negative item rates in Selling Settings Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #36642 (a0fc685) into develop (539cfd0) will increase coverage by 0.05%.
Report is 15 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36642      +/-   ##
===========================================
+ Coverage    64.77%   64.82%   +0.05%     
===========================================
  Files          792      792              
  Lines        61779    61798      +19     
===========================================
+ Hits         40018    40063      +45     
+ Misses       21761    21735      -26     
Files Changed Coverage Δ
erpnext/accounts/report/financial_statements.py 80.42% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 83.71% <100.00%> (-0.09%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.11% <100.00%> (+0.05%) ⬆️
erpnext/controllers/status_updater.py 88.42% <100.00%> (+0.06%) ⬆️

... and 7 files with indirect coverage changes

@tdci
Copy link

tdci commented Aug 15, 2023

the toggle should be the other way around.
the option should be the on customer that do not want a negative rate "Disable negative rates for items" on their invoices.
this should not break anything prior to the last push.

@ruthra-kumar ruthra-kumar merged commit d77b029 into frappe:develop Aug 15, 2023
14 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Aug 15, 2023
ruthra-kumar added a commit that referenced this pull request Aug 16, 2023
…-36642

refactor: toggle for negative item rates in Selling Settings (backport #36642)
@tukutela
Copy link
Contributor

Thankyou!!!!!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants