Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tax withholding reversal on Debit Notes #36799

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

deepeshgarg007
Copy link
Member

There is no tax withholding reversal on the creation of returns against Purchase Invoices. Ideally whatever amount is reversed using a Debit Note the corresponding Tax Withheld should also be reversed.

@deepeshgarg007 deepeshgarg007 added the needs-tests This PR needs automated unit-tests. label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #36799 (6d9cebf) into develop (e93b927) will increase coverage by 0.00%.
Report is 41 commits behind head on develop.
The diff coverage is 83.33%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #36799   +/-   ##
========================================
  Coverage    65.19%   65.20%           
========================================
  Files          792      792           
  Lines        61814    61861   +47     
========================================
+ Hits         40299    40334   +35     
- Misses       21515    21527   +12     
Files Changed Coverage Δ
erpnext/controllers/sales_and_purchase_return.py 87.14% <50.00%> (-0.24%) ⬇️
...x_withholding_category/tax_withholding_category.py 92.42% <100.00%> (ø)
..._receivable_summary/accounts_receivable_summary.py 92.15% <100.00%> (ø)

... and 16 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Aug 24, 2023
@deepeshgarg007 deepeshgarg007 merged commit 1449e38 into frappe:develop Aug 24, 2023
13 of 14 checks passed
deepeshgarg007 added a commit that referenced this pull request Aug 25, 2023
…-36799

fix: Tax withholding reversal on Debit Notes (#36799)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant