Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(demo): Default accounts for demo company #36804

Merged
merged 3 commits into from
Aug 24, 2023
Merged

fix(demo): Default accounts for demo company #36804

merged 3 commits into from
Aug 24, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Aug 24, 2023 •
edited by ankush
Loading

Country-specific demo data issues

  • Demo data generation fails if no non group income and expense accounts are present in COA
    • Fixed for Indonesia and UAE
    • Added fallbacks
  • Fallback for roundoff account

closes #36635

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 24, 2023
@deepeshgarg007 deepeshgarg007 merged commit abc5fdd into frappe:develop Aug 24, 2023
11 of 13 checks passed
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve demo data #2
1 participant
@deepeshgarg007