Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allocation error on partial payment against sales order #36844

Merged
merged 3 commits into from Aug 28, 2023
Merged

fix: allocation error on partial payment against sales order #36844

merged 3 commits into from Aug 28, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 28, 2023 •
edited

  1. Make Sales Order with a rounding adjustment amount.
  2. Make partial payment for [1]. Save and Submit.
  3. Make another partial payment for [1]. Upon save, allocation based validation error is thrown.
    This happend as get_reference_details was fetching grand_total rather than rounded_total.
Screenshot 2023-08-28 at 2 24 22 PM

@ruthra-kumar ruthra-kumar merged commit 9895bc3 into frappe:develop Aug 28, 2023
11 of 12 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Aug 28, 2023
@mergify mergify bot mentioned this pull request Aug 28, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Aug 28, 2023
@ruthra-kumar
Merge pull request #36847 from frappe/mergify/bp/version-14-hotfix/pr…
e8d7d30 
…-36844

fix: allocation error on partial payment against sales order (backport #36844)
@ruthra-kumar ruthra-kumar mentioned this pull request Aug 29, 2023
Closed
@ruthra-kumar ruthra-kumar linked an issue Aug 29, 2023 that may be closed by this pull request
can’t do more than one payment entry for the sales order #36834
Closed
@blaggacao blaggacao mentioned this pull request Sep 17, 2023
Merged
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can’t do more than one payment entry for the sales order
1 participant
@ruthra-kumar