Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unreconcile Payments #36879

Merged
merged 29 commits into from
Sep 14, 2023
Merged

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 30, 2023

Feature

Ability to unreconcile payments from invoices without cancellation.

  • Is bi-directional (can be done from Invoice as well as payment)
  • Supports unlinking of Individual Invoices
  • Handles Multi-Currency invoices and its associated Exc Gain/Loss JE's automatically

Limitations

For Journal Entries, unreconciliation is restricted to JE's that credit a Receivable account or debit a Payable account. In other words, JE's that act as a Payment in ERPNext parlance.

Demo

unreconcile.mp4

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #36879 (d398775) into develop (f7865da) will increase coverage by 0.00%.
Report is 13 commits behind head on develop.
The diff coverage is 68.42%.

@@            Coverage Diff            @@
##           develop   #36879    +/-   ##
=========================================
  Coverage    65.55%   65.56%            
=========================================
  Files          796      798     +2     
  Lines        62718    62860   +142     
=========================================
+ Hits         41114    41213    +99     
- Misses       21604    21647    +43     
Files Changed Coverage
...xt/accounts/doctype/payment_entry/payment_entry.py ø
...xt/accounts/doctype/sales_invoice/sales_invoice.py ø
erpnext/controllers/accounts_controller.py 33.33%
...ctype/unreconcile_payments/unreconcile_payments.py 55.73%
erpnext/accounts/utils.py 97.91%
...ile_payment_entries/unreconcile_payment_entries.py 100.00%

@ruthra-kumar ruthra-kumar removed the WIP label Sep 14, 2023
@ruthra-kumar ruthra-kumar marked this pull request as ready for review September 14, 2023 06:47
@ruthra-kumar ruthra-kumar merged commit 85ebaa3 into frappe:develop Sep 14, 2023
11 of 19 checks passed
@rmehta
Copy link
Member

rmehta commented Sep 15, 2023

"Un reconcile" button should be hidden inside a menu (Actions?) - it looks too visible for a non-primary action.

@ruthra-kumar
Copy link
Member Author

"Un reconcile" button should be hidden inside a menu (Actions?) - it looks too visible for a non-primary action.

Makes sense. Will move it.

@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Oct 9, 2023
ruthra-kumar added a commit that referenced this pull request Oct 10, 2023
…-36879

feat: Unreconcile Payments (backport #36879)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants