-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Unreconcile Payments #36879
Merged
ruthra-kumar
merged 29 commits into
frappe:develop
from
ruthra-kumar:unreconcile_feature
Sep 14, 2023
Merged
feat: Unreconcile Payments #36879
ruthra-kumar
merged 29 commits into
frappe:develop
from
ruthra-kumar:unreconcile_feature
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #36879 +/- ##
=========================================
Coverage 65.55% 65.56%
=========================================
Files 796 798 +2
Lines 62718 62860 +142
=========================================
+ Hits 41114 41213 +99
- Misses 21604 21647 +43 |
exchange gain/loss associated with the unreconcile invoice should be cancelled as well
082ec67
to
d398775
Compare
"Un reconcile" button should be hidden inside a menu (Actions?) - it looks too visible for a non-primary action. |
Makes sense. Will move it. |
This was referenced Sep 15, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Oct 10, 2023
…-36879 feat: Unreconcile Payments (backport #36879)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Ability to unreconcile payments from invoices without cancellation.
Limitations
For Journal Entries, unreconciliation is restricted to JE's that credit a
Receivable
account or debit aPayable
account. In other words, JE's that act as a Payment in ERPNext parlance.Demo
unreconcile.mp4