Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce threshold for background job in PCV #36900

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

GursheenK
Copy link
Member

Problem
The function to evaluate if the processing of GL entries in PCV should be done in a background job does not consider the number of closing entries.

Solution
Added closing entries in the condition for evaluating if the process will take place in the background job.
Reduced the threshold to ensure if entries are more than 3000, the process should use a background job.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #36900 (b6e6f2e) into develop (cd74c6c) will decrease coverage by 0.01%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #36900      +/-   ##
===========================================
- Coverage    65.42%   65.42%   -0.01%     
===========================================
  Files          794      794              
  Lines        62194    62194              
===========================================
- Hits         40690    40689       -1     
- Misses       21504    21505       +1     
Files Changed Coverage
...e/period_closing_voucher/period_closing_voucher.py 100.00%

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Sep 2, 2023
@deepeshgarg007 deepeshgarg007 merged commit 30aba94 into frappe:develop Sep 2, 2023
14 checks passed
deepeshgarg007 added a commit that referenced this pull request Sep 2, 2023
…-36900

fix: reduce threshold for background job in PCV (#36900)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants