Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: gain/loss je should use same posting date as payment #36950

Merged

Conversation

ruthra-kumar
Copy link
Member

Gain/Loss JE should use the same posting date as the Payment it is referencing

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Sep 4, 2023
@ruthra-kumar ruthra-kumar force-pushed the use_reference_posting_date_on_je branch from 746300e to 6e5b981 Compare September 4, 2023 15:14
@ruthra-kumar ruthra-kumar changed the title refactor: gain/loss should use same posting date as payment refactor: gain/loss je should use same posting date as payment Sep 4, 2023
@ruthra-kumar ruthra-kumar force-pushed the use_reference_posting_date_on_je branch from 6e5b981 to f7865da Compare September 4, 2023 16:11
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #36950 (f7865da) into develop (75d95ac) will decrease coverage by 0.01%.
Report is 20 commits behind head on develop.
The diff coverage is 79.97%.

@@             Coverage Diff             @@
##           develop   #36950      +/-   ##
===========================================
- Coverage    65.55%   65.55%   -0.01%     
===========================================
  Files          796      796              
  Lines        62717    62718       +1     
===========================================
  Hits         41114    41114              
- Misses       21603    21604       +1     
Files Changed Coverage
...e/payment_reconciliation/payment_reconciliation.py ø
erpnext/assets/doctype/asset/asset.py 0.00%
...ctype/asset_capitalization/asset_capitalization.py ø
...ctype/stock_reconciliation/stock_reconciliation.py ø
...rpnext/stock/report/stock_balance/stock_balance.py ø
...next/stock/report/reserved_stock/reserved_stock.py 46.66%
erpnext/controllers/accounts_controller.py 50.00%
...ext/stock/doctype/stock_settings/stock_settings.py 50.00%
erpnext/stock/doctype/pick_list/pick_list.py 56.86%
erpnext/stock/stock_ledger.py 66.66%
... and 15 more

@ruthra-kumar ruthra-kumar merged commit 13ca474 into frappe:develop Sep 5, 2023
13 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Sep 5, 2023
ruthra-kumar added a commit that referenced this pull request Sep 5, 2023
…-36950

refactor: gain/loss je should use same posting date as payment (backport #36950)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant