fix: Packed item incorrectly picks expired price on Sales Order #37057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
requested review from
rohitwaghchaure,
s-aga-r and
deepeshgarg007
as code owners
ruthra-kumar
changed the title
ruthra-kumar
force-pushed
the
packed_item_picking_expired_price
branch
from
bdce366
to
055156d
Compare
|
unrelated test case failure: https://github.com/frappe/erpnext/actions/runs/6167199944/job/16737808115?pr=37057 |
ruthra-kumar
added a commit
that referenced
this pull request
Sep 13, 2023
…-37057 fix: Packed item incorrectly picks expired price on Sales Order (backport #37057)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate Product Bundle Price based on Child Items' Ratesin Selling Settingsvalid_uptolesser than Sales Order transaction date) for a child item of the product bundleExpired Item price should not be picked.