Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Customer and Supplier - Primary Address and Contact on the same column as new address and contact #37190

Merged

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Sep 21, 2023

Please provide enough information so that others can review your pull request:

On Contact & Adress tab on Customer and Supplier
In section "Address and Contact" : the first column is for address and the second for contact
but
in section "Primary Address and Contact" : the first column is for contact and the second is for address
It's confusing that the same kind of information aren't place in the same column on the same page

Explain the details for making this change. What existing problem does the pull request solve?

Use Update DocType in developper mode (with this awesome new feature of drag and drop form) to switch the two panels in "Primary Address and Contact" section

Screenshots/GIFs

Before
image

After
image

no-docs

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #37190 (fb84492) into develop (f0859ec) will decrease coverage by 0.07%.
Report is 3 commits behind head on develop.
The diff coverage is 4.91%.

@@             Coverage Diff             @@
##           develop   #37190      +/-   ##
===========================================
- Coverage    66.76%   66.70%   -0.07%     
===========================================
  Files          793      794       +1     
  Lines        62423    62483      +60     
===========================================
+ Hits         41679    41680       +1     
- Misses       20744    20803      +59     
Files Changed Coverage
...ort/stock_ledger_variance/stock_ledger_variance.py 0.00%
...xt/accounts/doctype/payment_entry/payment_entry.py 60.00%

@bosue
Copy link
Contributor

bosue commented Sep 22, 2023

I love how you reorganized this, following the vertical columns rather than horizontal sections, which is way more adequate given our eyes’ capabilities and customs.

Now the left column just needs the header “Adresses” and the right column the header “Contacts,” and then it looks clean and is easy to grasp.

@deepeshgarg007 deepeshgarg007 merged commit 12e16aa into frappe:develop Sep 24, 2023
14 of 15 checks passed
@FHenry FHenry deleted the dev_feat_adress_contact_postion branch September 25, 2023 08:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants