fix(sales): add sales user to read stock settings for js refresh code path #37317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
erpnext/erpnext/selling/doctype/sales_order/sales_order.js
Lines 91 to 101 in e7f4b7b
^^ This is a code path exercised by evey Sales User when e.g. creating a new sales order.
However the Sales User, alone, doesn't have access to Stock Settings.
This is clearly not working as intendet because there's no way a User with only Sale User role can actually, well, create a new Sale Order.
Every such time, the user is greated with a permission error message and the potentially important default setting on stock reservation is silently ignored as if it was disabled.
Proposed Solution