Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyerror on gl and pl comparision report #37495

Merged

Conversation

ruthra-kumar
Copy link
Member

Traceback (most recent call last):
File "apps/frappe/frappe/core/doctype/prepared_report/prepared_report.py", line 79, in generate_report
result = generate_report_result(report=report, filters=instance.filters, user=instance.owner)
File "apps/frappe/frappe/__init__.py", line 802, in wrapper_fn
retval = fn(*args, **get_newargs(fn, kwargs))
File "apps/frappe/frappe/desk/query_report.py", line 89, in generate_report_result
res = get_report_result(report, filters) or []
File "apps/frappe/frappe/desk/query_report.py", line 70, in get_report_result
res = report.execute_script_report(filters)
File "apps/frappe/frappe/core/doctype/report/report.py", line 131, in execute_script_report
res = self.execute_module(filters)
File "apps/frappe/frappe/core/doctype/report/report.py", line 148, in execute_module
return frappe.get_attr(method_name)(frappe._dict(filters))
File "apps/erpnext/erpnext/accounts/report/general_and_payment_ledger_comparison/general_and_payment_ledger_comparison.py", line 219, in execute
columns, data = rpt.run()
File "apps/erpnext/erpnext/accounts/report/general_and_payment_ledger_comparison/general_and_payment_ledger_comparison.py", line 208, in run
self.compare()
File "apps/erpnext/erpnext/accounts/report/general_and_payment_ledger_comparison/general_and_payment_ledger_comparison.py", line 144, in compare
self.diff[(x[0], x[1], x[2], x[3])].update(frappe._dict({"pl_balance": x[4]}))

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 13, 2023
@ruthra-kumar ruthra-kumar merged commit f4a294c into frappe:develop Oct 14, 2023
11 of 13 checks passed
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Oct 14, 2023
ruthra-kumar added a commit that referenced this pull request Oct 14, 2023
…-37495

fix: keyerror on gl and pl comparision report (backport #37495)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant