New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: payments irrespective of party types #37828
Merged
deepeshgarg007
merged 9 commits into
frappe:develop
from
GursheenK:payments-irrespective-of-party-types
Nov 9, 2023
Merged
fix: payments irrespective of party types #37828
deepeshgarg007
merged 9 commits into
frappe:develop
from
GursheenK:payments-irrespective-of-party-types
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #37828 +/- ##
===========================================
+ Coverage 67.33% 67.41% +0.08%
===========================================
Files 757 757
Lines 60147 60326 +179
===========================================
+ Hits 40497 40666 +169
- Misses 19650 19660 +10
|
GursheenK
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
November 6, 2023 05:28
deepeshgarg007
requested changes
Nov 8, 2023
erpnext/accounts/utils.py
Outdated
|
||
|
||
def get_party_types_from_account_type(account_type): | ||
return frappe.db.get_list("Party Type", {"account_type": account_type}, pluck="name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use get_all
instead of get_list
, get_list
might cause unwanted permission issues
deepeshgarg007
added a commit
that referenced
this pull request
Nov 9, 2023
…-37828 fix: payments irrespective of party types (backport #37828)
This was referenced Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, when a Payment Entry is created, the ledger entries that get generated are configured in a way that does not allow the following scenarios -
Solution
Resolves #37124
no-docs