Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calculation of P/L in balance sheet #39048

Merged
merged 3 commits into from Jan 13, 2024

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Dec 31, 2023

General Ledger

Bildschirmfoto 2023-12-31 um 14 17 00

Rows Description
2, 3 25,000.00 received via bank transfer (equity)
4, 5, 6 119.00 received via bank transfer (100.00 revenue, 19.00 VAT)
7, 8 19.00 paid via bank transfer (advance payment of VAT, offsetting the VAT liability)

Balance Sheet (Before)

Bildschirmfoto 2023-12-31 um 14 16 13

Balance Sheet (After)

Bildschirmfoto 2023-12-31 um 14 15 03

Important

I'm not sure why [-2] was used in the first place, if this was ever correct and, if so, what broke it. Some deeper analysis might still be needed.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 31, 2023
@barredterra barredterra force-pushed the fix-pl-balance-sheet branch 5 times, most recently from 2e9caa9 to f49a211 Compare January 2, 2024 18:39
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Jan 2, 2024
@barredterra
Copy link
Collaborator Author

barredterra commented Jan 2, 2024

The added test case is passing:

Bildschirmfoto 2024-01-03 um 00 47 06

Unrelated unit test failing (fails on many unrelated PRs)

@deepeshgarg007 deepeshgarg007 merged commit 3b14c59 into frappe:develop Jan 13, 2024
11 of 12 checks passed
@barredterra barredterra deleted the fix-pl-balance-sheet branch January 13, 2024 11:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants