-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use Text Editor
for rendering tax breakup table
#40563
Merged
deepeshgarg007
merged 2 commits into
frappe:develop
from
GursheenK:tax-breakup-table-docfield
Mar 20, 2024
Merged
fix: use Text Editor
for rendering tax breakup table
#40563
deepeshgarg007
merged 2 commits into
frappe:develop
from
GursheenK:tax-breakup-table-docfield
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
March 20, 2024 10:51
styles are kinda whacked |
@Mergifyio backport version-15 |
@Mergifyio backport version-14 |
✅ Backports have been created
|
✅ Backports have been created
|
This was referenced Mar 20, 2024
GursheenK
added a commit
that referenced
this pull request
Mar 20, 2024
…-40563 fix: use `Text Editor` for rendering tax breakup table (backport #40563)
GursheenK
added a commit
that referenced
this pull request
Mar 20, 2024
fix: use `Text Editor` for rendering tax breakup table (backport #40563)
GursheenK
added a commit
that referenced
this pull request
Mar 20, 2024
…-40563 fix: use `Text Editor` for rendering tax breakup table (backport #40563)
deepeshgarg007
added a commit
that referenced
this pull request
Mar 20, 2024
fix: use `Text Editor` for rendering tax breakup table (backport #40563)
This was referenced Mar 25, 2024
This was referenced Mar 27, 2024
This was referenced Mar 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
needs-tests
This PR needs automated unit-tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Tax breakup table shows HTML code instead of rendering the content correctly after this fix.
Fix
Use the
Text Editor
field instead of theLong Text
field type.Closes frappe/frappe#25558