Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Text Editor for rendering tax breakup table #40563

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

GursheenK
Copy link
Member

@GursheenK GursheenK commented Mar 20, 2024

Bug

Tax breakup table shows HTML code instead of rendering the content correctly after this fix.

Screenshot 2024-03-20 at 4 36 55 PM

Fix

Use the Text Editor field instead of the Long Text field type.

Screenshot 2024-03-20 at 5 37 10 PM

Closes frappe/frappe#25558

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 20, 2024
@deepeshgarg007 deepeshgarg007 marked this pull request as ready for review March 20, 2024 10:51
@ankush
Copy link
Member

ankush commented Mar 20, 2024

styles are kinda whacked

@deepeshgarg007 deepeshgarg007 merged commit 9863574 into frappe:develop Mar 20, 2024
14 checks passed
@deepeshgarg007
Copy link
Member

@Mergifyio backport version-15

@ankush ankush added the backport version-14-hotfix backport to version 14 label Mar 20, 2024
@ankush
Copy link
Member

ankush commented Mar 20, 2024

@Mergifyio backport version-14

Copy link
Contributor

mergify bot commented Mar 20, 2024

backport version-15

✅ Backports have been created

Copy link
Contributor

mergify bot commented Mar 20, 2024

backport version-14

✅ Backports have been created

GursheenK added a commit that referenced this pull request Mar 20, 2024
…-40563

fix: use `Text Editor` for rendering tax breakup table (backport #40563)
GursheenK added a commit that referenced this pull request Mar 20, 2024
fix: use `Text Editor` for rendering tax breakup table (backport #40563)
GursheenK added a commit that referenced this pull request Mar 20, 2024
…-40563

fix: use `Text Editor` for rendering tax breakup table (backport #40563)
deepeshgarg007 added a commit that referenced this pull request Mar 20, 2024
fix: use `Text Editor` for rendering tax breakup table (backport #40563)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tax Breakup is Showing Raw HTML in Purchase Order (Frappe Version 15.8)
3 participants