Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inspection type when create a qc from dc #41013

Merged
merged 1 commit into from Apr 23, 2024
Merged

fix: inspection type when create a qc from dc #41013

merged 1 commit into from Apr 23, 2024

Conversation

Nihantra-Patel
Copy link
Contributor

Versions 15 and 14

fixes: https://discuss.frappe.io/t/create-button-in-delivery-note-not-working-properly/121130

Before:

  • When creating a quality inspection from a delivery note, it takes an incoming inspection type because it is statically set.
before_qc.mp4

After:

after_qc.mp4
  • Added the dynamic conditions to fix the inspection type.

@github-actions github-actions bot added the stock label Apr 15, 2024
@rohitwaghchaure rohitwaghchaure merged commit eadd892 into frappe:develop Apr 23, 2024
19 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
stock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nihantra-Patel @rohitwaghchaure