fix: TDS incorrectly applied when Advance is in previous FY #41194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthra-kumar
force-pushed
the
fix_incorrectly_applying_tds_when_advance_in_prev_fiscal_year
branch
from
4a6997c
to
b195f51
Compare
ruthra-kumar
added
backport version-14-hotfix
ruthra-kumar
changed the title
This was referenced Apr 30, 2024
ruthra-kumar
added a commit
that referenced
this pull request
Apr 30, 2024
…-41194 fix: TDS incorrectly applied when Advance is in previous FY (backport #41194)
ruthra-kumar
added a commit
that referenced
this pull request
Apr 30, 2024
…-41194 fix: TDS incorrectly applied when Advance is in previous FY (backport #41194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Advance with TDS deducted is in previous fiscal year, Invoices in current fiscal year still get TDS applied, if there multiple invoices. Fixing in this PR.
Replication:
The combination of the 2 invoices should breach the cumulative threshold, and the total TDS for those invoices should be greater than the TDS deducted from the Advance Payment.
ps: TCS/TDS related code are long overdue for a refactor.