Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: French chart of account the 4191 code must be of type Income Account #41232

Merged
merged 3 commits into from
May 31, 2024

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Apr 29, 2024

Default french chart of account have an error, Account "4191 - Clients - Avances et acomptes reçus sur commandes" must be of type Income Account because should be set on Item Default.income_account

Copy link

stale bot commented May 15, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 15, 2024
@FHenry
Copy link
Contributor Author

FHenry commented May 15, 2024

hi @ruthra-kumar , @deepeshgarg007 could you have a look for this PR ?

failed CI test is not related

@stale stale bot removed the inactive label May 15, 2024
Copy link

stale bot commented May 31, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label May 31, 2024
@ruthra-kumar ruthra-kumar self-assigned this May 31, 2024
@stale stale bot removed the inactive label May 31, 2024
@ruthra-kumar ruthra-kumar merged commit 07c4212 into frappe:develop May 31, 2024
13 checks passed
@FHenry
Copy link
Contributor Author

FHenry commented May 31, 2024

@ruthra-kumar ruthra-kumar
Could you add "back-port version-15" tag please ?

ruthra-kumar added a commit that referenced this pull request Jun 1, 2024
…-41232

fix: French chart of account the 4191 code must be of type Income Account (backport #41232)
@FHenry FHenry deleted the dev_fix_french_chart_of_account branch June 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants