Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depreciation based on daily prorata #41235

Merged
merged 8 commits into from
May 15, 2024

Conversation

khushi8112
Copy link
Collaborator

@khushi8112 khushi8112 commented Apr 29, 2024

Bug: On the selection of depreciation based on daily prorata, it should happen on the basis of prorata.
Screenshot 2024-04-29 at 4 32 24 PM

Fix: After the fix it will get the per day depreciation by dividing the whole year depreciation with the number of days that year. And then depreciation amount will be calculated on the basis of frequency of depreciation and "total number of depreciation".
Screenshot 2024-05-07 at 11 24 27 AM
Screenshot 2024-05-07 at 11 25 58 AM
no-docs

@khushi8112 khushi8112 force-pushed the depreciation_based_daily_prorata branch from 6725652 to 7b264e5 Compare May 14, 2024 14:42
@nabinhait nabinhait disabled auto-merge May 15, 2024 02:37
@nabinhait nabinhait merged commit fc79783 into frappe:develop May 15, 2024
13 checks passed
nabinhait added a commit that referenced this pull request May 15, 2024
…-41235

Depreciation based on daily prorata (backport #41235)
@khushi8112 khushi8112 changed the title Depreciation based on daily prorata fix: depreciation based on daily prorata May 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants