Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negative stock qty error for stock reconciliation #41283

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented May 1, 2024

Steps To Replicate Issue

  1. Create Purchase Receipt for 10 Qty with Batch Item (First Batch)
  2. Create Deliver Note for 1 Qty balance qty 9 (First Batch)
  3. Create Deliver Note for 1 Qty balance qty 8 (First Batch)
  4. Create Deliver Note for 1 Qty balance qty 7 (First Batch)
  5. Create Deliver Note for 1 Qty balance qty 6 (First Batch)
  6. Create Deliver Note for 1 Qty balance qty 5 (First Batch)
  7. Create Deliver Note for 1 Qty balance qty 4 (First Batch)
  8. Create Purchase Receipt for 3 Qty with Batch Item (Second Batch)
  9. Create Stock Reco against the First batch and keep qty as 9
  10. Create Deliver Note for 3 Qty balance qty against the second batch
  11. Create Deliver Note for 3 Qty balance qty 6 (Second Batch)
  12. Create Deliver Note for 3 Qty balance qty 3 (Second Batch)
  13. Create Deliver Note for 3 Qty balance qty 0 (Second Batch)
  14. Now Cancel the delivery note which was created at step 7
  15. Delivery Note get cancel but when you try to complete reposting, system will throw the negative stock error.

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels May 1, 2024
@rohitwaghchaure rohitwaghchaure merged commit 9aa054c into frappe:version-14-hotfix May 2, 2024
11 of 12 checks passed
frappe-pr-bot pushed a commit that referenced this pull request May 2, 2024
# [14.69.0](v14.68.2...v14.69.0) (2024-05-02)

### Bug Fixes

* 'NoneType' object has no attribute '_read_rowdata_packet_unbuffered' ([949aa93](949aa93))
* args when get the delivery note in delivery trip ([abe64aa](abe64aa))
* args when get the delivery note in delivery trip ([1a7b3c4](1a7b3c4))
* display term name for single term invoices ([58b68b7](58b68b7))
* duplicate column in the stock ledger report ([3fcdcef](3fcdcef))
* handle stock balance unbuffered_cursor error (backport [#41186](#41186)) ([#41187](#41187)) ([59010c9](59010c9))
* incorrectly applying TDS when Advance is in previous FY ([eb22fb9](eb22fb9))
* mode of payment has precedance ([33d38ba](33d38ba))
* multiple pricing rules with discount amount and discount percentage not working ([#41211](#41211)) ([54313b5](54313b5))
* negative stock qty error for stock reconciliation ([#41283](#41283)) ([9aa054c](9aa054c))
* permission issue when user permission restricts on company ([45c4167](45c4167))
* validation to prevent overallocation ([8318286](8318286))

### Features

* allow to do reposting for all stock transactions (audit) (backport [#41165](#41165)) ([#41205](#41205)) ([1e13193](1e13193))

### Performance Improvements

* timeout issue while submitting purchase receipt (v14) ([113351e](113351e))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.69.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests. released stock
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants