Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group same item in SO print #6959

Merged
merged 1 commit into from
Nov 18, 2016
Merged

Group same item in SO print #6959

merged 1 commit into from
Nov 18, 2016

Conversation

KanchanChauhan
Copy link
Contributor

screen shot 2016-11-16 at 2 44 01 pm

nabinhait
nabinhait reviewed Nov 16, 2016
View reviewed changes
Copy link
Member

@nabinhait nabinhait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put group_same_items() function under accounts_controller.py inside the Class. That way it will be available for both sales and purchase order and you don't have to pass doc.

@KanchanChauhan
Copy link
Contributor Author

Changes done

@rmehta rmehta merged commit 49a50fe into frappe:develop Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait approved these changes

@vladucoju vladucoju vladucoju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KanchanChauhan @nabinhait @vladucoju @rmehta