Update lead.py #8789
Merged
Update lead.py #8789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import datetime to compare next contact date with now()
|
What is the use case? |
|
resolves the below issue |
nabinhait
requested changes
May 16, 2017
erpnext/crm/doctype/lead/lead.py
Outdated
| @@ -45,7 +46,7 @@ def validate(self): | |||
|
|
|||
| self.image = has_gravatar(self.email_id) | |||
|
|
|||
| if self.contact_date and self.contact_date < now(): | |||
| if self.contact_date and self.contact_date < datetime.now(): | |||
There was a problem hiding this comment.
datetime.now() can create problem with user date format.
Instead use nowdate() function from frappe.utils
getdate(self.contact_date) < getdate(nowdate())
As per the suggestion from Nabin,instead of Datetime,getdate and nowdate from frappe.utils imported
nabinhait
pushed a commit
that referenced
this pull request
May 24, 2017
* Update lead.py Import datetime to compare next contact date with now() * Update lead.py * Update lead.py As per the suggestion from Nabin,instead of Datetime,getdate and nowdate from frappe.utils imported
nabinhait
added a commit
that referenced
this pull request
May 24, 2017
This reverts commit 9283377.
nabinhait
added a commit
that referenced
this pull request
May 24, 2017
This reverts commit 9283377.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import datetime to compare next contact date with now()