Added a reference of Sales Invoice in Serial No #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauskar
force-pushed
the
serial-nos
branch
2 times, most recently
from
01f073e
to
4a7f7cd
Compare
nabinhait
requested changes
May 19, 2017
| serial_nos = item.serial_no or "" | ||
| si_serial_nos = set(serial_nos.split("\n")) | ||
|
|
||
| if si_serial_nos - dn_serial_nos: |
There was a problem hiding this comment.
For partial invoicing, it will always be different. You need to check for each serial no.
| """ | ||
|
|
||
| for item in self.items: | ||
| if not item.delivery_note and not item.dn_detail: |
| @@ -83,6 +83,7 @@ def validate(self): | |||
| self.validate_c_form() | |||
| self.validate_time_sheets_are_submitted() | |||
| self.validate_multiple_billing("Delivery Note", "dn_detail", "amount", "items") | |||
| self.validate_serial_numbers() | |||
| @@ -125,6 +126,7 @@ def on_submit(self): | |||
| self.update_against_document_in_jv() | |||
|
|
|||
| self.update_time_sheet(self.name) | |||
| self.update_serial_no() | |||
| @@ -160,6 +162,7 @@ def on_cancel(self): | |||
|
|
|||
| self.make_gl_entries_on_cancel() | |||
| frappe.db.set(self, 'status', 'Cancelled') | |||
| self.update_serial_no(in_cancel=True) | |||
| sales_invoice = item.get("parent", None) | ||
| serial_nos = item.get("serial_no", "") | ||
|
|
||
| if not sales_invoice and not serial_no: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for #8804
after