[Fix] Orders not creating from the POS for new customer if customer name is based on naming series #8933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
from
044dd6c
to
6e246bd
Compare
|
@mbauskar Can you test this? |
mbauskar
approved these changes
May 25, 2017
mbauskar
suggested changes
May 25, 2017
…ame is based on naming series
…s disabled in POS profile
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
from
6e246bd
to
4c6be49
Compare
|
@mbauskar Fixed! |
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
6 times, most recently
from
c57091d
to
783c3a5
Compare
mbauskar
approved these changes
May 31, 2017
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
from
783c3a5
to
2503f5e
Compare
nabinhait
requested changes
Jun 2, 2017
| "in_standard_filter": 0, | ||
| "label": "Customer POS ID", | ||
| "length": 0, | ||
| "no_copy": 0, |
| "no_copy": 0, | ||
| "permlevel": 0, | ||
| "precision": "", | ||
| "print_hide": 0, |
| "columns": 0, | ||
| "fieldname": "customer_pos_id", | ||
| "fieldtype": "Data", | ||
| "hidden": 0, |
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
from
2503f5e
to
588f5a2
Compare
mbauskar
approved these changes
Jun 5, 2017
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
from
8d50722
to
89456d1
Compare
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
3 times, most recently
from
7b3a7c0
to
697d67c
Compare
rohitwaghchaure
force-pushed
the
pos_customer_issue_for_naming_series
branch
from
697d67c
to
449e443
Compare
tundebabzy
pushed a commit
to tundebabzy/erpnext
that referenced
this pull request
Jun 13, 2017
…ame is based on naming series (frappe#8933) * [Fix] Orders not creating from the POS for new customer if customer name is based on naming series * [fix] Disabled price field in POS, if Allow User to Edit Rate field is disabled in POS profile * added customer name in the search bar of the customer * search customer by phone number and email id in the POS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Customer name by naming series
Fixed #8923
Fixed #8621
Fixed #9110