fixes #8941: Better error message for duplicate items #8968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add the before and after screenshot? It will be easier to review the PR, Please check |
mbauskar
suggested changes
May 25, 2017
| try: | ||
| item = get_duplicates(lst).next() | ||
| if item: | ||
| return item |
There was a problem hiding this comment.
instead of returning single item return list of duplicate items, e.g. if raw material has items A, B, B, C, C then return list [B, C] as multiple items
|
@mbauskar Sorry about that. Noted. After |
|
Changed to show all duplicates. They are displayed in an After |
mbauskar
suggested changes
Jun 6, 2017
| if duplicate_items: | ||
| li = [] | ||
| for i in duplicate_items: | ||
| li.append("<li>{0} on row {1}".format(i.item_code, i.idx)) |
There was a problem hiding this comment.
close the li tag <li>{0} on row {1}</li>
Also can we keep the message simple? Just join the list of items with <br>?
There was a problem hiding this comment.
ok. That means no need for the <li> tags?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.