[fix] add round off difference to last row in landed cost voucher #8989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
requested changes
May 24, 2017
| pr.submit() | ||
|
|
||
| submit_landed_cost_voucher("Purchase Receipt", pr.name, 123.22) | ||
|
|
There was a problem hiding this comment.
Add a assertEqual statement as well, to compare the distributed charges value.
nabinhait
requested changes
May 24, 2017
| lcv = submit_landed_cost_voucher("Purchase Receipt", pr.name, 123.22) | ||
|
|
||
| self.assertEquals(lcv.items[0].applicable_charges, 41.07) | ||
| self.assertEquals(lcv.items[2].applicable_charges, 41.07999999999999) |
There was a problem hiding this comment.
It should be 42.08. What is the precision of the applicable_charges field?
nabinhait
approved these changes
May 26, 2017
ashwinisave35
added a commit
to ashwinisave35/erpnext
that referenced
this pull request
May 29, 2017
…t_issue * 'develop' of https://github.com/frappe/erpnext: bumped to version 8.0.40 [fix] uppercase filter frappe#8996 (frappe#9026) Financial Statements Button translateabled (frappe#9032) [minor] added get_terms methods to erpnext.utils so that it can be used in non transactional documents (frappe#9037) Party Dashboard: Consider any random company if default company not set (frappe#9046) [fix] add round off difference to last row in landed cost voucher (frappe#8989) Update code to fix issue #erpnext WN-SUP25349 : ValueError: max() arg is an empty sequence. (frappe#9025) add milestone field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.