make quotation against lead's company name #9188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
requested changes
Jun 14, 2017
erpnext/crm/doctype/lead/lead.py
Outdated
| @@ -151,7 +151,7 @@ def make_quotation(source_name, target_doc=None): | |||
| "doctype": "Quotation", | |||
| "field_map": { | |||
| "name": "lead", | |||
| "lead_name": "customer_name", | |||
| "lead_name": "company_name", | |||
There was a problem hiding this comment.
In quotation, there is no field called "company_name".
The correct fix will be, remove the line "lead_name": "customer_name",. set_missing_values does the mapping correctly.
mbauskar
pushed a commit
to mbauskar/erpnext
that referenced
this pull request
Jun 21, 2017
mbauskar
added a commit
that referenced
this pull request
Jun 21, 2017
make quotation against lead company name (#9188)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9171