Fix and improve shopping cart

[britlog]

• Fix login page redirect when putting product in cart
• Products ordered by item name (after weightage)
• Fix shopping cart crash when removing the last product from cart
• Don't display tax in cart if amount is zero
• Translations

[rmehta]

@britlog thanks for the PR. Can you add an animated GIF to show that this works. Since the users are concerned about stability, we want to ensure that user testing is done at your end. You can use LiceCAP to take an animated GIF.

Please re-open when done

[britlog]

@rmehta Done, but I can't reopen it because it was not closed by myself, could you please do it ? Thanks

[rmehta]

Thanks! The strawberries look delicious 🍓

[frappe-pr-bot]

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Test Case Not Added / Updated

Since you have changed a Python file, you must update the relevant python test case. If there is no test coverage for this code, then please add it.

---

Result

• Failed: User testing is mandatory for patches with changes in JS code.

• Passed: Small Pull Request

---

This summary was automatically generated based on this script

[rmehta]

this is important, as per the new develop branch (frappe), we have reduced the use of globals. Please check.

[britlog]

I 've noticed frappe.session.user_fullname was empty, so i just revert to the last version which worked but indeed use global. Thanks for review.

[britlog]

There is a typing error on frappe word if(fraappe.session.user==="Guest")

[rmehta]

Thanks fixed.

…

On 20-Jun-2017, at 1:29 PM, Britlog ***@***.***> wrote: @britlog commented on this pull request. In erpnext/public/js/shopping_cart.js <#9348 (comment)>: > @@ -35,10 +35,8 @@ $.extend(shopping_cart, { }); }, - update_cart: function(opts) { - var full_name = frappe.session && frappe.session.user_fullname; - - if(!full_name || full_name==="Guest") { + update_cart: function(opts) { + if(fraappe.session.user==="Guest") { There is a typing error on frappe word if(fraappe.session.user==="Guest") — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#9348 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIjLI6weHDc1f319vaCjHhBhb3ZNSvNks5sF3v2gaJpZM4N9mka>.

[sophatvathana]

Ok